qinchaoyue 5 місяців тому
батько
коміт
cbb3ca9740

+ 1 - 1
src/Hotline.Api/Controllers/KnowledgeController.cs

@@ -175,7 +175,7 @@ namespace Hotline.Api.Controllers
 
             kn.Status = EKnowledgeStatus.Drafts;
             kn.InitId();
-            if (dto.Data.Files.IsNullOrEmpty() == false) kn.FileJson = await _fileRepository.AddFileAsync(dto.Data.Files, kn.Id, "", HttpContext.RequestAborted);
+            if (dto.Data.Files.NotNullOrEmpty() == false) kn.FileJson = await _fileRepository.AddFileAsync(dto.Data.Files, kn.Id, "", HttpContext.RequestAborted);
             await _knowledgeRepository.AddAsync(kn, HttpContext.RequestAborted);
 
             if (dto.Data.KnowledgeType.Any())

+ 14 - 0
src/Hotline.Application.Tests/Application/KnowApplicationTest.cs

@@ -105,4 +105,18 @@ public class KnowApplicationTest
             e.Message.ShouldBe("热词已存在");
         }
     }
+
+    /// <summary>
+    /// 测试扩展方法是否能正确判断集合空和非空的情况
+    /// </summary>
+    [Fact]
+    public void ListEx_Test()
+    {
+        List<string> a = null;
+        a.IsNullOrEmpty().ShouldBeTrue();
+        a.NotNullOrEmpty().ShouldBeFalse();
+        a = new List<string>();
+        a.IsNullOrEmpty().ShouldBeTrue();
+        a.NotNullOrEmpty().ShouldBeFalse();
+    }
 }

+ 1 - 1
src/Hotline.Share/Dtos/CallCenter/TelDto.cs

@@ -66,7 +66,7 @@ namespace Hotline.Share.Dtos.CallCenter
 
         public List<TelGroupDto> Groups { get; set; }
 
-        public string GroupsNo => Groups.IsNullOrEmpty() ? Groups.FirstOrDefault().No : "";
+        public string GroupsNo => Groups.NotNullOrEmpty() ? Groups.FirstOrDefault().No : "";
 
 		#region 添润
 

+ 5 - 0
src/Hotline.Share/Tools/ListExtensions.cs

@@ -8,6 +8,11 @@ namespace Hotline.Share.Tools;
 public static class ListExtensions
 {
     public static bool IsNullOrEmpty<T>(this List<T> value)
+    {
+        return value == null || value.Count == 0;
+    }
+
+    public static bool NotNullOrEmpty<T>(this List<T> value)
     {
         return value != null && value.Count != 0;
     }